Update REFPROPMixtureBackend.cpp #2374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coolprop library does not implement the function call setrefdll from Refprop. As a result, there are discrepancies between the calculation results of Refprop and Coolprop when computing predefined mixture MIX models, primarily in terms of standard state deviations (which affect enthalpy values and related quantities). Coolprop does provide a method to set the standard state, which can be set to DEF. However, the default value of DEF in Coolprop still differs from the calculation results of Refprop.
|
|
|
It is not true that CoolProp does not implement the SETREFdll function of REFPROP. But it is true that the default reference state is not set to match that of REFPROP by default for predefined mixtures. |
Yes, you are right. I misspoke. Will this pull request be merged? Is there an issue with the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coolprop library does not implement the function call setrefdll from Refprop. As a result, there are discrepancies between the calculation results of Refprop and Coolprop when computing predefined mixture MIX models, primarily in terms of standard state deviations (which affect enthalpy values and related quantities).
Coolprop does provide a method to set the standard state, which can be set to DEF. However, the default value of DEF in Coolprop still differs from the calculation results of Refprop.
Requirements
Description of the Change
Based on the previously mentioned issue (#2239),
Coolprop library does not implement the function call setrefdll from Refprop. As a result, there are discrepancies between the calculation results of Refprop and Coolprop when computing predefined mixture MIX models, primarily in terms of standard state deviations (which affect enthalpy values and related quantities).
Coolprop does provide a method to set the standard state, which can be set to DEF. However, the default value of DEF in Coolprop still differs from the calculation results of Refprop.
Benefits
[ The modified code now includes the call to setrefdll from refprop, resulting in the same calculations as those set in refprop when computing predefined mixtures. ]
Possible Drawbacks
[The original user's calculations for predefined mixtures will be affected by the changes, but only when using the REFPROP backend. This will primarily impact variables such as enthalpy values. ]
Verification Process
[ What process did you follow to verify that your change has the desired effects?
I only verified R410A.MIX and did not conduct extensive testing, but I believe the impact should be minimal and feasible.
Applicable Issues
Closes #2239