New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Dipole moment addition #1701
base: master
Are you sure you want to change the base?
Conversation
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Value is 0 because monatomic molecules don't have a dipole defined.
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are C*m. Data reported at: https://cccbdb.nist.gov/diplistx.asp
Units are in C*m. Cyclohexane is a non-polar molecule and has no dipole moment, see: https://ch301.cm.utexas.edu/section2.php?target=imfs/polar/dipole-moment.html
Thanks for what you've done so far - looking good. What's the game plan here? Collect all of them and then bump the PR? |
Yeah. I'll continue to add data to the files, and then push more commits for the coding to read the dipole moment data. |
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Only source that could be located which reported a dipole moment for D4: https://www.gelest.com/product/octamethylcyclotetrasiloxane-98/
Only source that could be located which reported a dipole moment for D5: https://www.gelest.com/product/decamethylcyclopentasiloxane/
Only source that could be located which reported a dipole moment for D6: https://www.gelest.com/product/dodecamethylcyclohexasiloxane/
Actual dipole moment is actually 0.0 for cyclopentane based on "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell. The previous value was mis-read.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Value tabulated in: Haynes, William M., ed. (2011). CRC Handbook of Chemistry and Physics (92nd ed.). Boca Raton, FL: CRC Press. ISBN 1439855110.
Value tabulated in "The Properties of Gases and Liquids" 5th edition, Poling, Prausnitz, and O'Connell.
Valued located at: http://www.ethermo.us/ShowDetail2821.htm
@wandadars - I updated your PR text at the top to include the verification checks. I only spot checked a few fluids, but the values match the JSON files, zeroes are returned where they should be and fluids with @ibell - If you're ok with this, I'll squash and merge. |
Before you squash and merge, can I please run a sanity check on the values
to make sure they agree (at least relatively) with REFPROP? Or if someone
else could do this test, even better
|
Great idea. I’ll automate a check against REFPROP for all fluids. |
@ibell Most values are pretty close. My computer is going down until Monday, so I'll print a full report later. @wandadars , just a few look suspect, when compared to the values in REFPROP. Please recheck references for:
The rest that you put in look pretty good. 3 out of 122 - Not bad! CoolProp has a few fluids that REFPROP does not, so there is no comparison value. |
Ok. I'm convinced on cyclohexane. REFPROP lists a very slight dipole moment for cyclohexane, but I don't believe it. The very weak C-H polarity and the molecule symmetry means it's zero. |
ethylbenzene: I see references for 0.359 D, certainly closer to your value, but I also see references for 0.58 D and 0.59 D (NIST). |
Nitrous Oxide (N2O) - NIST lists the dipole moment at 0.167 D. Other sources list similar. |
Since I can't do this easily currently, can you (@henningjp) dump a CSV listing of the new dipole moments and their values in REFPROP into this issue? |
@ibell Yep. Already created, but my computer is down while I install new floor in my office. Hope to be back up and running this weekend. (Posting from iPhone) |
@ibell OK, back up and running. Value table (csv with a txt extension) comparing to REFPROP results attached. |
The alkane values in REFPROP seem correct after discussion with @EricLemmon
and searching some references online. Where did the values in CoolProp
come from?
|
In the commit message for each fluid I should have included the exact reference that I used to obtain the value. |
Yeah, I think the ethermo.us values are perhaps not correct :/ The values
in Poling's book seem to be more reliable.
…On Sun, Oct 21, 2018 at 3:23 PM Chris Neal ***@***.***> wrote:
In the commit message for each fluid I should have included the exact
reference that I used to obtain the value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1701 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxha4nNcNelhPexQiGjPX1Hy9pixY2Dks5unHVAgaJpZM4UVsEc>
.
|
@ibell Should we create an additional dipole_moment_source key that holds the reference source string right in the JSON file? I think if it is not accessed by the code it would be a valuable comment in each file as to where the values come from, especially since there is some discrepancy between sources. Would that extra key be innocuous? |
Yes, that would be great! In fact I proposed that some time ago in this
thread.
|
@wandadars , you or me? I don't want to duplicate effort if you're already making these keys for the source string in each JSON. Either way is fine with me. |
@henningjp I haven't started any work on adding the additional keys. I'm busy with some other things this week, so I won't be able to get started anytime soon if you want to take a crack at adding those keys. |
@wandadars Sorry for the delay. It's a long sad story of corrupted local git repositories, lost files, and having to repeat the work all over again. I made a new PR to your branch that contains the following:
To verify everything I took the following steps:
|
Clean up JSON fluid files and add source reference field dipole_moment_refs
@wandadars Here are a few remaining precision issues to check against Poling and two with the Geleste references. They are nit-picky, but they should be double checked. If the Poling values are accurate, then I'm fine with them as the difference is small and they are newer than the CCDBD and NBS10 references used heavily by REFPROP. Thanks.
|
@wandadars , @ibell suggested a target of 1% difference from the REFPROP values; however, this may not be reasonable given some of the very small values. A survey of the fluids that do not agree with REFPROP are listed in the tables below with comments and a suggested resolution. (NOTE: the rest of the fluids in the library agree 100% with the REFPROP values.) For a few of the fluids in the table, I land on the side of the submitted values (newer, confirmed references over the REFPROP source) and a few (???) have non-reconciled differences. References are only used that we can actually lay eyes on and I do not have access to DIPPR, which is used for several of the REFPROP values. If anyone has issue with the proposed resolutions, or has suggestions on the non-reconciled differences, or can provide a better reference value, please comment.
Fluids with no dipole moment values listed in REFPROP
Once we're agreed on the resolutions above, I'll add to the PR with the above resolutions. |
@ibell, @wandadars, will you have time to look these over and comment on the resolutions proposed? How should we proceed? This is really close to being a solid implementation with only a few missing values for a few new/obscure refrigerants. |
@ibell - What do you want to do with this? I can wrap it up, but I think it needs a completely new PR as it's quite outdated. I think I've got reasonable assessments of the values (what to include, what to leave undefined) in the previous comments. However, I've not heard anything back from you on direction in a very long time. Is this worth finishing up? |
@henningjp - It would indeed be great to get this into CoolProp. Sorry I've been not as responsive on this thread as I might like. I agree that a fresh PR might be the way to go given its age. |
I don't think I can dig into the nitty gritty of the values where diescrepancies occur, but where we are all in agreement about what the value should be, let's get those in. Also, this quantity is much mushier than it seems, so I think my 1% target was likely ambitious. Maybe more like 5% would do. |
Requirements
**I'm looking for help on what other files I need to change in order to make the dipole_moment attribute that I add to the database file accessible within CoolProp.
For now I am working on just getting the data into the JSON files.
Description of the Change
added "dipole_moment" attribute to JSON fluid files for species where the data for the dipole moment is available. The units in the JSON files can be in either the standard literature
Debye [D]
unit or inC*m
(Where C is Coulomb). The values are stored and returned from CoolProp inC*m
, which is an SI unit.Benefits
The dipole moment can be used in some thermodynamic calculations.
Possible Drawbacks
Incorrect value of the dipole_moment
Verification Process (@henningjp)
Files were compiled and tested in both Python (3.6):
and Mathcad Prime (4.0 & 5.0):
If the dipole moment is not available, it is listed as -1 in the fluid JSON file and results in an error as shown in the examples above for the fluid SES36.
Applicable Issues
Addresses one of the wish-list component from issue #115.