updated compile.sh with cmake build of coolprop libray #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Script build the CoolProp sources into a shared library, then compile the fluent udf into shared objects and finally it links the udf shared objects with the CoolProp shared library into the libudf.so
|
|
ibell
requested changes
Oct 20, 2017
|
|
||
| #CoolProp root source file (where CMakelist.txt is) --> adapt the following line | ||
| CoolProp_sources_repository="/usersCFD/epd/ah33666/CoolProp-6.1.0" | ||
| #Python 2.7 is mandatory to use cmake, by default on our machines the Python version is 2.4 --> adapt the following line |
There was a problem hiding this comment.
Not really, any modern version of python can be used, including 3.x
| cd $HOME | ||
|
|
||
| #CoolProp root source file (where CMakelist.txt is) --> adapt the following line | ||
| CoolProp_sources_repository="/usersCFD/epd/ah33666/CoolProp-6.1.0" |
There was a problem hiding this comment.
This should probably be read in from an environment variable or passed as a command line argument rather than being hard coded. Can you please change that?
| mkdir CoolProp_Build | ||
| cd CoolProp_Build | ||
| #uncomment following line for make file generation if python version <2.7 | ||
| cmake -G "Unix Makefiles" -DCOOLPROP_EXTERNC_LIBRARY:BOOL="ON" -DCOOLPROP_SHARED_LIBRARY:BOOL="ON" -DPYTHON_EXECUTABLE:FILEPATH=$PYTHON_273 $CoolProp_sources_repository |
There was a problem hiding this comment.
I don't understand what is going on here. It should work just fine with any non-ancient version of python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Script build the CoolProp sources into a shared library, then compile the fluent udf into shared objects and finally it links the udf shared objects with the CoolProp shared library into the libudf.so