Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HS_INPUTS in tabular interpolation #2318

Open
Marcoliveti97 opened this issue Nov 23, 2023 · 10 comments
Open

HS_INPUTS in tabular interpolation #2318

Marcoliveti97 opened this issue Nov 23, 2023 · 10 comments

Comments

@Marcoliveti97
Copy link

Hi everybody!
Do you know why the enthalpy-entropy pair of input is not supported for the tabular backend?
It one of the most common pair for many problems, thanks to the total enthalpy conservation, but unfortunately it seems to be unavailable. Do you think it could be soon implemented?

Thank you for your work

@ibell
Copy link
Contributor

ibell commented Nov 26, 2023 via email

@Marcoliveti97
Copy link
Author

Hi Ian and thanks for your reply.
I could help implementing the routine, but my lack of proficiency in C++ would make it extremely inefficient.
If you know somebody among the developer interested in the topic I could work with him in this implementation.
Let me know!

@ibell
Copy link
Contributor

ibell commented Dec 3, 2023

Maybe @msaitta-mpr ?

@msaitta-mpr
Copy link
Contributor

Is your idea to make a new h/s table, or perform a 1D solver on the existing p/h table?

@Marcoliveti97
Copy link
Author

I don't really know how the tables are originally created, but I'd say that if the table is generated through p and h, a double interpolation should be enough to get a value from a given h and s. Am I incorrect?

@msaitta-mpr
Copy link
Contributor

It should be possible to simply iterate on s, but there will be a reduction in speed. Often the reason that people use the tables is for the increased property lookup speed. I wasn't sure what you had in mind.

I can take a look into implementing an h/s input pair routine that uses such a routine.

@Marcoliveti97
Copy link
Author

That's true, but I don't expect it to be slower than calling the EOS with h and s as inputs.
This would however allow consistency in codes where look-up tables are used, avoiding to call EOS (or PropsSI) whenever hs are used as inputs.

@Marcoliveti97
Copy link
Author

Hello!
Is there any update on the issue? Do you think is it something that will be added to the code?

Thank you :)

@msaitta-mpr
Copy link
Contributor

I have been playing around with the new code. However, I am still working to implement a solver for the saturation curves. Currently, they are tabulated by P/T, so a solver needs to be implemented to determine which phase (or two-phase) the state point is in. There are similar methods in the HEOS module, but I will need some more time to move one of them over and make it compatible.

@Marcoliveti97
Copy link
Author

Excellent! Thank you for your time and dedication and for considering this request. Let me know if I can be of help in any way or if there is any news!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants