Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The docs are broken since md-January #2349

Open
jowr opened this issue Feb 12, 2024 · 3 comments · May be fixed by #2351
Open

The docs are broken since md-January #2349

jowr opened this issue Feb 12, 2024 · 3 comments · May be fixed by #2351

Comments

@jowr
Copy link
Member

jowr commented Feb 12, 2024

I think this commit broke the docs: 443a2fd

See run 673 of the documentation builder for details, maybe @msaitta-mpr could have a look?

@ibell
Copy link
Contributor

ibell commented Feb 12, 2024

My first guess is that it is not related to that PR, but I am not sure where that error is coming from.

@msaitta-mpr
Copy link
Contributor

Looks like the issue in in the TTSE tables. I didn't touch them in 443a2fd (#2250).

 ValueError: Cell is invalid and has no good neighbors for x = 46916.8, y= 400000
Traceback (most recent call last):
  File "/__w/CoolProp/CoolProp/Web/scripts/__init__.py", line 98, in <module>
    run_script(os.path.normpath(fname))
  File "/__w/CoolProp/CoolProp/Web/scripts/__init__.py", line 59, in run_script
    subprocess.check_call('python -u {0}'.format(file_name), cwd=file_path, shell=True)
  File "/opt/conda/envs/docs/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'python -u coolprop.tabular.speed.py' returned non-zero exit status 1.

This looks strangely similar to some errors that I have been getting while investigating for #2318. I will try to find some more time this week to dive back into that and hopefully figure out what is going on with the doc builds at the same time.

@msaitta-mpr msaitta-mpr linked a pull request Feb 16, 2024 that will close this issue
@msaitta-mpr
Copy link
Contributor

OK, this was an interesting one. You were right that 443a2fd broke it. There was in issue with the secondary check on convergence missing one of the possible acceptable states.

I have created a PR that should address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants