Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise AggregatingIterator in MatchingDataAttestationGroup #8307

Merged
merged 8 commits into from
May 15, 2024
Merged

Optimise AggregatingIterator in MatchingDataAttestationGroup #8307

merged 8 commits into from
May 15, 2024

Conversation

StefanBratanov
Copy link
Contributor

PR Description

Reuse streamRemainingAttestations() which we call in hasNext() in next()

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the optimize_iterator branch 4 times, most recently from d23ed0e to 13743f8 Compare May 14, 2024 12:49
tbenr
tbenr approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 1a3feda into Consensys:master May 15, 2024
16 checks passed
@StefanBratanov StefanBratanov deleted the optimize_iterator branch May 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StefanBratanov @tbenr