let forkChoice onTick fail #8096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Mar 18, 2024
| tickProcessor.onTick(currentTimeMillis).get(30, TimeUnit.SECONDS); | ||
| } catch (final InterruptedException | TimeoutException | ExecutionException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| performanceRecord.ifPresent(TickProcessingPerformance::tickProcessorComplete); |
There was a problem hiding this comment.
i think it's worth doing this finish in an 'always' block
also, we should probably put in a counter for failed ticks...
|
potentially given the stacktrace we looked at, raised #8097 as an alternative |
|
i think if we do this, we'd plumb it in so we can tweak the value, and we'd start it high. I like the idea that timedTick can timeout, but being able to alter that value if its too low sometimes would be much easier if we could do it with cli arg... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** NEEDS TO BE CAREFULLY ANALYZED ***
If there are possible deadlock conditions, we should avoid "joining" forever and let timeout so we can allow deadlock to resolve. We should double-check and, if we fail, we remain in a recoverable state, not in a broken-corrupted state.