feat: As a developer, I or portal owner should be able to revoke or replace the attestation #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is own attestation
satyajeetkolhapure
requested review from
alainncls,
orbmis and
0xEillo
as code owners
orbmis
reviewed
Jan 24, 2024
| */ | ||
| function bulkReplace( | ||
| bytes32[] calldata attestationIds, | ||
| AttestationPayload[] calldata attestationPayloads, | ||
| address attester | ||
| address replacer |
There was a problem hiding this comment.
Will this introduce breaking changes for existing portals?
| */ | ||
| function revoke(bytes32 attestationId) public { | ||
| function revoke(bytes32 attestationId, address revoker) public { |
There was a problem hiding this comment.
If the revoker argument is being specified by the contract calling this method, then surely it can be spoofed? Am I wrong?
There was a problem hiding this comment.
Actually, the Attestation registry will always be called from the portal that has implemented the abstract portal. The abstract portal has revoke and replace methods that cannot be overridden. The abstract portal has getAttester method which returns msg sender.
As it is recommended not to use tx origin, the best way is to get the attester from the Abstract portal.
I will still have a look if there is any possibility of it.
alainncls
force-pushed
the
dev
branch
4 times, most recently
from
581c2b6
to
f607329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Along with the portal owner, an attester who attested the attestation should be able to revoke or replace his attestation too.
Related ticket
Fixes #546
Type of change
Check list