feat(tx-init): initial implementation of TX_INIT phase #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerslider
force-pushed
the
feat/issue-660/tx-init
branch
from
4eb140b
to
514588e
Compare
letypequividelespoubelles
requested changes
May 23, 2024
| @@ -117,6 +119,17 @@ | |||
| @Slf4j | |||
| @Accessors(fluent = true) | |||
| public class Hub implements Module { | |||
| private static final Set<Address> PRECOMPILE_ADDRESSES = | |||
There was a problem hiding this comment.
It's already in AdressUtils.java
Remove from here plz
| deploymentInfo.number(fromAddress), | ||
| deploymentInfo.isDeploying(fromAddress)); | ||
|
|
||
| // TODO: still no finished |
There was a problem hiding this comment.
is it finished now ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #660
Signed-off-by: Tsvetan Dimitrov tsvetan.dimitrov@consensys.net