Arithmetization v2 - DO NOT MERGE #596
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delehef
changed the title
delehef
force-pushed
the
arith-dev
branch
4 times, most recently
from
07e212e
to
e72319a
Compare
* feat(txnData): add check callData is zero * style: spotless * style: column renaming * fix(constraint): ras * feat(constraint): ras
* perf(BIN): adaptative nb line * fix(bin): rebase fix * feat: column typing * fix(constraint): ras * fix: ras * fix: corset export * feat(constraint): rebase * feat(constraint): ras
* feat(constraint): ras * build: fix RLP modules trace creation * feat: fradle Trace * feat(rlp*): add phase column * style(rlpTxn): phase starts at 1 instead of 0 * feat(constraint): ras --------- Co-authored-by: Franklin Delehelle <franklin.delehelle@odena.eu>
Signed-off-by: franklin.delehelle@consensys.net Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Add @EqualsAndHashCode.Include to hubStamp. * Calculate line count based on which precompile is called. Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Fixes #303 --------- Co-authored-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net> Co-authored-by: Franklin Delehelle <franklin.delehelle@odena.eu> Co-authored-by: delehef <franklin.delehelle@consensys.net>
Signed-off-by franklin.delehelle@consensys.net
Dropping failing transactions initial state is plain stupid, as they will fail due to their initial state.
Co-authored-by: Franklin Delehelle <franklin.delehelle@odena.eu>
Signed-off-by: franklin.delehelle@consensys.net Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: franklin.delehelle@consensys.net
Resolves: #635 Signed-off-by: Lorenze Gentile <lorenzo.gentile.consensys.net>
Resolves: #667 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Resolves: #667 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Resolves: #667 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Resolves: #681 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Resolves: #681 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net> Co-authored-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
* feat(rlpaddr): add lookup to trm * fix: files forgotten * style: camelCase for local variable
* feat: remimplement txnData * fix: debug * fix(txnData): partly fix cumulativeGasUsed * fix: cumulative gas in a block is sum of gas used - refund in each tx * test(rlpAddr): too much gas * feat(txndata): rename package from txn_data to txndata * fix: changes in constraints * fix: faulthy package import --------- Co-authored-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
* feat: add mechanism to count rows not yet in traced operation * perf: from sum over stack to cumulative Deque
* feat(blockdata,-blockhash): module implementation * feat: implement blockhash * fix: debug * test(blockhash): add tests * build: fix module renaming * test: accurate values for block default values * style: spotless * test: write relevant default value in block creation * feat(constraints): add constraint * style: review * test: delete non relevant test
* feat(txndata): implement eip 3529 * feat(constraint): updtae * style: spotless
* fix(exp): kill duplicate * fix: typo * fix: stacklist != stackset * fix(exp): minor naming fixes * fix(exp): improved naming and organization of classes * fix(exp): improved naming * style: spotless --------- Co-authored-by: Lorenzo Gentile <lorenzogentile404@gmail.com>
* feat(rlpaddr): add keccak result selector column * fix: constraints update
* feat(shakira-data): add initial implementation * feat: connect ShakiraData module to RipeMD and SHA256 precompile calls * feat: refine implementation according to the spec * feat(shakira): connect to keccak call and fix inconsistencies in the implementation * feat(shakira): improve keccak triggering and fix issues * feat(shakira): change phase flag mechanism * feat(shakiradata): wip * feat(shakiradata): reimplement module * fix: cleaning + from Stack to Deque * fix: typo * style: cleaning * style(ecpairing): make it more logical (OB's comment) * fix(trace-gradle): rebase issue for txndata * feat: no memory allocation * feat(shakira): needs two padding row * feat(shakira): ass result selector for shakira * feat(shakira): stack arg in consistent order --------- Co-authored-by: Francois Bojarski <francois.bojarski@consensys.net>
* feat(romlex): no more empty bytecode and add codehash columns * feat(constraints): update * build(constraints): update
* feat(ecdata): updated trace file and partially Operation * feat(ecdata): managed ecrecover case and common columns * fix(ecdata): fixed bugs related to assemble method and lookups * feat(ecdata): fixed BYTE_DELTA * feat(ecdata): computed recoveredAddress and made tests parametric * feat(ecdata): printed recovered address for debugging purposes * feat(ecdata): completed test of ecrecover * feat(ecdata): added code for id debugging * fix(ecdata): solved bug related to usage of Bytes.of * fix(ecdata): update constraints submodule reference * fix(shfreftable): turned MSHP into an UnsignedByte * fix(ecdata): previousId --------- Co-authored-by: Francois Bojarski <francois.bojarski@consensys.net>
* Implement OOB * OOB fixed slice usage * OOB fixed ToyExecutionEnvironment after rebase * OOB fixed ByteCodeRunner, OobTests and partially updated module after rebase * OOB updated trace class and classes dependent from it * OOB update wip * OOB renamed precompiles methods * OOB fixed common precompiles * OOB updated blake2f and fixed common precompiles * OOB updated modexp * OOB updated setModexpLead * OOB completed update of modexp, review is needed * OOB fixed comments * OOB fixed maxMbsBbs * OOB fixed comp * OOB updated spillings.toml file * OOB fixed module key * OOB fixed minor bugs relared to prc-modexp_cds and hub justification predictions * OOB reactivated random offset in the tests for precompiles * OOB used parametrized junit tests * OOB substituted assert with assertEquals * fix(oob): renaming and refinements * fix(oob): reverted some renaming and fixed issue with replicated constants * fix(oob): removed assert from tests and getOob from byteCodeRunner and toyExecutionEnvironment * fix(oob): fixed trace-files.gradle after merge * fix(oob): update according to new constants file * fix: wrong constants * fix: fixed bug related to gas limit in BytecodeRunner * fix(oob): fixed call number * fix(oob): filled DATA 7 and 8 for opcodes still wip with 0 * fix(oob): fixed minor issues after review, major issue missing oob in modules to count * fix(oob): added EqualsAndHashCode * fix: removed unused class --------- Co-authored-by: Lorenzo Gentile <lorenzogentile404@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.