Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fflonk #498

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Feat/fflonk #498

wants to merge 46 commits into from

Conversation

ThomasPiellard
Copy link
Contributor

Description

Implementation of shplonk
Implementation of fflonk (only the commitment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • see fflonk_test.go
  • see shplonk_test_go

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested review from Tabaie and yelhousni and removed request for Tabaie April 26, 2024 16:36
Copy link

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:132: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-377/fflonk/fflonk_test.go:132
        	Error:      	Received unexpected error:
        	            	Fr does not contain all the t-th roots of 1
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bls12-378/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-378/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bls12-381/fflonk
TestFflonk 100ms

    fflonk_test.go:80: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-381/fflonk/fflonk_test.go:80
        	Error:      	Received unexpected error:
        	            	invalid polynomial size (larger than SRS or == 0)
        	Test:       	TestFflonk

TestGetIthRootOne 0s

    fflonk_test.go:132: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-381/fflonk/fflonk_test.go:132
        	Error:      	Received unexpected error:
        	            	Fr does not contain all the t-th roots of 1
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bls24-317/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:132: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls24-317/fflonk/fflonk_test.go:132
        	Error:      	Received unexpected error:
        	            	Fr does not contain all the t-th roots of 1
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bw6-756/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-756/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bw6-761/fflonk
TestFflonk 290ms

    fflonk_test.go:80: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-761/fflonk/fflonk_test.go:80
        	Error:      	Received unexpected error:
        	            	invalid polynomial size (larger than SRS or == 0)
        	Test:       	TestFflonk

TestGetIthRootOne 0s

    fflonk_test.go:132: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-761/fflonk/fflonk_test.go:132
        	Error:      	Received unexpected error:
        	            	Fr does not contain all the t-th roots of 1
        	Test:       	TestGetIthRootOne

Copy link

📦 github.com/consensys/gnark-crypto/ecc/bls12-381/fflonk
TestFflonk 80ms

    fflonk_test.go:80: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-381/fflonk/fflonk_test.go:80
        	Error:      	Received unexpected error:
        	            	invalid polynomial size (larger than SRS or == 0)
        	Test:       	TestFflonk

TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-381/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bls24-315/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls24-315/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bw6-761/fflonk
TestFflonk 200ms

    fflonk_test.go:80: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-761/fflonk/fflonk_test.go:80
        	Error:      	Received unexpected error:
        	            	invalid polynomial size (larger than SRS or == 0)
        	Test:       	TestFflonk

TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-761/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

@ThomasPiellard ThomasPiellard marked this pull request as draft April 26, 2024 16:46
Copy link

📦 github.com/consensys/gnark-crypto/ecc/bls12-381/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls12-381/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bls24-315/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bls24-315/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

📦 github.com/consensys/gnark-crypto/ecc/bw6-761/fflonk
TestGetIthRootOne 0s

    fflonk_test.go:140: 
        	Error Trace:	/home/runner/work/gnark-crypto/gnark-crypto/ecc/bw6-761/fflonk/fflonk_test.go:140
        	Error:      	An error is expected but got nil.
        	Test:       	TestGetIthRootOne

@ThomasPiellard ThomasPiellard marked this pull request as ready for review May 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant