Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tellor to Oracles Section #536

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

cryptobanjo
Copy link

No description provided.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ❌ Failed (Inspect) May 29, 2024 2:12pm

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution — my suggestions are mainly just applying sentence case. However, there are a few blockers to mention:

  • We need a front matter/metadata section at the start of the file — see my comment for more info.
  • We're actively migrating off Linea Goerli and I don't want to merge any new content that specifically relates to Linea Goerli, as this file does. As I described in another comment, I'd recommend we either merge without the testnet contract addresses (potentially with a placeholder suggesting it'll be updated soon), or we wait until you're able to update this PR to replace them with Sepolia addresses. Up to you which is best.
  • You need to make an entry in the appropriate section of sidebars.js — our sidebars are not autogenerated, so your page won't appear unless it's added there.

Thanks for your work on this.

docs/build-on-linea/tooling/oracles/tellor.md Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Outdated Show resolved Hide resolved
docs/build-on-linea/tooling/oracles/tellor.md Show resolved Hide resolved
@jlwllmr
Copy link
Collaborator

jlwllmr commented Apr 12, 2024

@cryptobanjo the linter is also picking up a few words it doesn't recognise — please add those to project-words.txt as well.

cryptobanjo and others added 8 commits April 15, 2024 13:55
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
Co-authored-by: jlwllmr <95916148+jlwllmr@users.noreply.github.com>
@jlwllmr
Copy link
Collaborator

jlwllmr commented Apr 22, 2024

@cryptobanjo apologies, forgot to mention earlier but please add this to the sidebar in sidebars.js, otherwise it won't appear on the site.

We also still need the words adding to project-words.txt like I mentioned above.

added tellor to oracle sidebar
@cryptobanjo
Copy link
Author

@cryptobanjo apologies, forgot to mention earlier but please add this to the sidebar in sidebars.js, otherwise it won't appear on the site.

We also still need the words adding to project-words.txt like I mentioned above.

updated sidebars and added "tellor" to project-words.tx - thanks

new sepolia contract addresses
@jlwllmr
Copy link
Collaborator

jlwllmr commented May 22, 2024

@cryptobanjo we need your help again here please:

  • Firstly to add additional words to project-words.txt
image - We recently restructured the docs — this mainly affects the path of your file (`build-on-linea` is now `developers`), but also the sidebar.

Could you merge main into your branch and resolve conflicts please? Many thanks!

added twap,vwap,incentivized,queryid,Autopay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants