Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to detached code #4441

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XAML-Knight
Copy link
Contributor

@XAML-Knight XAML-Knight commented Dec 27, 2021

Fixes #4440

Need to remove references to detached code, as they appear in the Community Toolkit Sample App as empty placeholders.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Detached code appears in the Sample App, as blank sample pages

What is the new behavior?

Detached code no longer appears in list of available pages, in the Sample App

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Unable to locate documentation that would suggest the empty sample pages could potentially contain hyperlinks to the new locations (on Github or NuGet) of the detached code.

@ghost
Copy link

ghost commented Dec 27, 2021

Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi December 27, 2021 22:54
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Dec 27, 2021
@Nirmal4G
Copy link
Contributor

Nirmal4G commented Jan 9, 2022

Docs still point to the correct location and can't we update the project links to the new location instead of completely removing those sections?

@michael-hawker
Copy link
Member

Yeah, these are currently here intentionally to provide discoverability to these more non-UI parts of the Toolkit:

image

If you don't have the docs repo checked-out locally during development though, they will indeed not show anything, but none of the docs appear if you're not doing that.

It's ok for us to have doc-only pages in the current sample app.

@michael-hawker
Copy link
Member

@Sergio0694 we should figure out a plan for how we want to handle at least the MVVM Sample app and getting that in the store, eh? @nmetulev maybe we need a toolkit publisher based account or something that we can use to centralize app submissions from?

@michael-hawker michael-hawker marked this pull request as draft January 20, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove samples.json references to detached code
4 participants