Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Akka Future to Java 8 CompletableFuture #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HaloFour
Copy link
Collaborator

This is a much simpler approach. I've updated the AkkaFutureAdapter class to instead convert the Akka Future[T] to a Java 8 CompletableFuture[T].

I've kept the Sirius interface the same as in that it continues to return Future[T] which would eliminate the potential for breaking a consumer which implements that interface directly, but that does put additional onus on the consumer to determine if the returned Future[T] is a CompletableFuture[T] or not.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2017

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants