Fix test password_does_not_match and improve CI workflow #73
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @borjapazr! Sorry for not reviewing this PR on time when you firstly submitted it. Our fault 🙏 However, I have received the close PR notification now, and the modifications seems totally appropriate. Would you mind if I reopen the PR and merge it? Thanks a lot for submitting it! |
|
Hi @JavierCane. You don't even have to apologize 😊. I was reviewing the old PRs I had opened and closed because I thought maybe you had already thought of another way to solve it. I'm happy to reopen it. Thanks for the feedback and for your day to day work 🚀 CodelyTV rocks! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the randomly generated password for the
AuthenticateUserCommandmatches the randomly generatedAuthUserpassword. Because of this, thethrow_an_exception_when_the_password_does_not_matchtest fails.This issue has been fixed and the GH Actions CI workflow has also been updated.