Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fragments when checking routes #185

Merged
merged 1 commit into from Mar 15, 2024
Merged

Conversation

cs278
Copy link
Contributor

@cs278 cs278 commented Feb 28, 2024

The following test fails:

$I->amOnRoute('payment_history', ['month' => '2020-07', '_fragment' => 'content']);
$I->seeCurrentRouteIs('payment_history');

With:

Step  See current route is "payment_history"
Fail  The "/payment-history/2020-07#content" url does not match with any route

@TavoNiievez
Copy link
Member

Hi @cs278 ,

We need a test for this change,
do you think you can create one in the module test project (codeception/symfony-module-tests) following the contribution guide?

Thanks!

@TavoNiievez TavoNiievez merged commit e45d5af into Codeception:main Mar 15, 2024
8 checks passed
@TavoNiievez
Copy link
Member

Released as 3.3.1

Thank you!

@TavoNiievez TavoNiievez added this to the 3.3.1 milestone Mar 15, 2024
@cs278 cs278 deleted the patch-1 branch March 17, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants