Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deleteHeader() to unsetHttpHeader() #22

Open
ThomasLandauer opened this issue Oct 3, 2020 · 3 comments
Open

Rename deleteHeader() to unsetHttpHeader() #22

ThomasLandauer opened this issue Oct 3, 2020 · 3 comments

Comments

@ThomasLandauer
Copy link
Member

ThomasLandauer commented Oct 3, 2020 •
edited

To be consistent with all other header functions: haveHttpHeader() (to which it is the counterpart), seeHttpHeader(), seeHttpHeaderOnce(), etc.

Also in lib-innerbrowser
@ThomasLandauer
Copy link
Member Author

Actually, "delete" isn't really the right term here. I'd say: Either unsetHttpHeader(), or (to be consistent with have...) dontHaveHttpHeader()

@SamMousa
Copy link
Contributor

A PR to fix this could be implemented without breaking BC. Just add an alias for the "wrong" function name and mark it deprecated.
Move the implementation to the "right" function name.

@ThomasLandauer ThomasLandauer mentioned this issue Oct 14, 2020
Open
ThomasLandauer added a commit to ThomasLandauer/module-rest that referenced this issue Oct 14, 2020
@ThomasLandauer
Update REST.php
546fca6 
See Codeception#22
@ThomasLandauer ThomasLandauer mentioned this issue Oct 14, 2020
Open
@ThomasLandauer
Copy link
Member Author

If you merge this, I'll do the same in lib-innerbrowser.

@Naktibalda Naktibalda changed the title Rename deleteHeader() to deleteHttpHeader() Rename deleteHeader() to unsetHttpHeader() Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamMousa @ThomasLandauer