Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setServerParameters() to haveServerParameters(); drop haveServerParameter() #26

Open
ThomasLandauer opened this issue Oct 14, 2020 · 1 comment

Comments

@ThomasLandauer
Copy link
Member

Just stumbled upon this while searching for a new name for deleteHeader(), see #22

Current situation:

I would say:

  • "setServerParameters" isn't the right term, Codeception's convention for this is "haveServerParameters".
  • It doesn't make sense to have two functions for this, one for a single parameter, and one for multiple. If the expected argument is an array, anybody knows immediately what to pass. So the existing haveServerParameter can be deprecated in favor of the new haveServerParameters.
  • Remaining question: Is the "Symfony BrowserKit" thing more of a bug or more of a feature?
    If feature: Just pass the array along to Symfony's setServerParameters, and that's it.
    If bug: foreach() over the array and use Symfony's setServerParameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant