Merge pull request #160 from bhoehl/invocation/missing/asserts

missing assertions for method call invocations
Codeception · Feb 29, 2020 · 72fc3d6 · 72fc3d6
2 parents da8b98a + 758413b
commit 72fc3d6
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/AspectMock/Proxy/Verifier.php b/src/AspectMock/Proxy/Verifier.php
@@ -1,5 +1,7 @@
 <?php
 namespace AspectMock\Proxy;
+
+use \PHPUnit\Framework\Assert;
 use \PHPUnit\Framework\ExpectationFailedException as fail;
 use AspectMock\Util\ArgumentsFormatter;
 
@@ -118,14 +120,18 @@ public function verifyInvokedMultipleTimes($name, $times, $params = null)
                     $equals++;
                 }
             }
-            if ($equals == $times) return;
+            if ($equals == $times) {
+                Assert::assertTrue(true);
+                return;
+            }
             $params = ArgumentsFormatter::toString($params);
             throw new fail(sprintf($this->invokedMultipleTimesFail, $this->className.$separator.$name."($params)", $times, $equals));
         } else if(is_callable($params)) {
             $params($calls);
         }
         $num_calls = count($calls);
         if ($num_calls != $times) throw new fail(sprintf($this->invokedMultipleTimesFail, $this->className.$separator.$name, $times, $num_calls));
+        Assert::assertTrue(true);
     }
 
     /**
@@ -153,6 +159,7 @@ public function verifyNeverInvoked($name, $params = null)
 
         if (is_array($params)) {
             if (empty($calls)) {
+                Assert::assertTrue(true);
                 return;
             }
 
@@ -161,11 +168,13 @@ public function verifyNeverInvoked($name, $params = null)
                     throw new fail(sprintf($this->neverInvoked, $this->className));
                 }
             }
+            Assert::assertTrue(true);
             return;
         }
         if (count($calls)) {
             throw new fail(sprintf($this->neverInvoked, $this->className.$separator.$name));
         }
+        Assert::assertTrue(true);
     }
 
 }