Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency cleanup #2776

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore: dependency cleanup #2776

wants to merge 5 commits into from

Conversation

jakemhiller
Copy link
Member

@jakemhiller jakemhiller commented Sep 13, 2023

Overview

  • remove babel-preset-codecademy usage
  • ran npx yarn-deduplicate & set up continuous deduplication

NOTE: This does change the code that is compiled by babel, so it will need to be tested before shipping.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@@ -34,7 +36,6 @@
"@typescript-eslint/parser": "^5.15.0",
"babel-jest": "29.6.4",
"babel-plugin-macros": "3.0.1",
"babel-preset-codecademy": "7.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because babel-preset-codecademy wasn't getting updated it ended up making our lockfile a mess. At this point it's very easy to set up a simple babel config that does what we need, without needing to manage all of the different dependencies that babel-preset-codecademy does.

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

eslint-plugin-gamut@2.0.5-alpha.ab0105.0
@codecademy/gamut@55.4.2-alpha.ab0105.0
@codecademy/gamut-icons@9.4.2-alpha.ab0105.0
@codecademy/gamut-illustrations@0.39.2-alpha.ab0105.0
@codecademy/gamut-kit@0.6.344-alpha.ab0105.0
@codecademy/gamut-patterns@0.9.9-alpha.ab0105.0
@codecademy/gamut-styles@16.1.4-alpha.ab0105.0
@codecademy/gamut-tests@5.0.8-alpha.ab0105.0
@codecademy/macros@3.0.4-alpha.ab0105.0
@codecademy/styleguide@66.2.2-alpha.ab0105.0
@codecademy/variance@0.21.2-alpha.ab0105.0

Base automatically changed from jh-syncpack-formatting to main September 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants