Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update objects.md #4579

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update objects.md #4579

wants to merge 3 commits into from

Conversation

usseoulusa
Copy link

@usseoulusa usseoulusa commented Apr 26, 2024

greeting() does not console.log and person.greeting() does not produce any output and requires console.log

Description

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

greeting() does not console.log and person.greeting() does not produce any output and requires console.log
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@mohitO12-dev mohitO12-dev self-assigned this Apr 30, 2024
@mohitO12-dev mohitO12-dev added new entry New entry or entries documentation Improvements or additions to documentation status: under review Issue or PR is currently being reviewed labels Apr 30, 2024
Copy link
Collaborator

@mohitO12-dev mohitO12-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added.

@mohitO12-dev mohitO12-dev added status: waiting for author and removed status: under review Issue or PR is currently being reviewed new entry New entry or entries labels May 5, 2024
I removed the double quotes and added a period at the end
Copy link
Collaborator

@mohitO12-dev mohitO12-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status: review 1️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants