Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] learning-rate-schedule.md (created) #4575

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

FuzzyNum
Copy link

Description

Created file learning-rate-schedule.md in docs/content/ai/concepts/neural_networks/terms/learning-rate-scheduling

Issue Solved

Closes #4530

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • [✅] All writings are my own.
  • [✅] My entry follows the Codecademy Docs style guide.
  • [✅] My changes generate no new warnings.
  • [✅] I have performed a self-review of my own writing and code.
  • [✅] I have checked my entry and corrected any misspellings.
  • [✅] I have made corresponding changes to the documentation if needed.
  • [✅] I have confirmed my changes are not being pushed from my forked main branch.
  • [✅] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [✅] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@FuzzyNum FuzzyNum changed the title Create learning-rate-schedule.md [Topic Entry] learning-rate-schedule.md (created) Apr 25, 2024
@raditya1117 raditya1117 self-assigned this Apr 27, 2024
@raditya1117 raditya1117 added new entry New entry or entries status: under review Issue or PR is currently being reviewed neural-networks Neural Networks labels Apr 27, 2024
Copy link
Collaborator

@raditya1117 raditya1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FuzzyNum,
Thanks for your contribution. The content looks good. However, I have proposed some minor changes. Please go through the comments and feel free to accept or reject the suggested changes as required.

@raditya1117 raditya1117 added status: review 1️⃣ completed status: waiting for author ai Artificial Intelligence entries and removed status: under review Issue or PR is currently being reviewed labels Apr 28, 2024
FuzzyNum and others added 11 commits April 28, 2024 15:10
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
@FuzzyNum
Copy link
Author

Thank you for your edits. I found them helpful and clarifying. I chose to apply all of them, let me know if there's any more changes you deem necessary!

@ishg-153 ishg-153 changed the title [Topic Entry] learning-rate-schedule.md (created) [Term Entry] learning-rate-schedule.md (created) Apr 29, 2024
@raditya1117
Copy link
Collaborator

@FuzzyNum, There are still some unresolved comments. Could you please check them?

@raditya1117
Copy link
Collaborator

@ishg-153
The issue mentioned for this PR was for a term entry, and the actual PR was for a Topic entry. As you rightly corrected, the PR should have been for a Term Entry. However, the content for the given topic cannot be written as a term entry due to its length, and I had considered it a topic entry as per the PR, which was a miss. Can we accept it as a Topic Entry instead of a Term entry? If we must convert it to a Term Entry, we must modify the format and remove most of the content. @rashi95

FuzzyNum and others added 3 commits April 30, 2024 13:01
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
@ishg-153
Copy link
Collaborator

Hey @raditya1117! I see what you mean. But since this term entry belongs under neural networks, we can't just make it a topic entry. A topic entry can only be made when that topic has many concepts within it and further, those concepts have a lot of terms that can have their individual entries.

FuzzyNum and others added 11 commits April 30, 2024 13:01
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
…ling/learning-rate-schedule.md

Co-authored-by: Aditya Raj <41803857+raditya1117@users.noreply.github.com>
@FuzzyNum
Copy link
Author

Hey @ishg-153, I intended to submit it as a term entry. What changes should be made to qualify it as such? In the content standards guide, I don't see a clear explanation of the conflict. I'm happy to update its format or modify it if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Artificial Intelligence entries neural-networks Neural Networks new entry New entry or entries status: review 1️⃣ completed status: waiting for author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Neural Networks ai Learning Rate Scheduling
4 participants