Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membership commands in comands topic #4551

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

fariamg
Copy link

@fariamg fariamg commented Apr 20, 2024

Add membership operators at operators topic

Description

Add an topic that describes the uses of membership operators (in and not in). The file in question is \docs\content\python\concepts\operators\operators.md

Issue Solved

#4583
Repaired the lack of membership operators in this topic. This membership operators is useful to check if some object contains another one.

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • [ x] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [ x] I have performed a self-review of my own writing and code.
  • [ x] I have checked my entry and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [ x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x] I have linked any issues that are relevant to this PR in the Issues Solved section.

Add membership operators at operators topic
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2024

CLA assistant check
All committers have signed the CLA.

@raditya1117 raditya1117 self-assigned this Apr 23, 2024
@raditya1117 raditya1117 added python Python entries status: under review Issue or PR is currently being reviewed new entry New entry or entries labels Apr 23, 2024
@dakshdeepHERE dakshdeepHERE added typo Fixing a typo and removed new entry New entry or entries labels Apr 24, 2024
Copy link
Collaborator

@raditya1117 raditya1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fariamg,
Nice contribution. Could you please review the suggested changes and accordingly accept or reject them?

content/python/concepts/operators/operators.md Outdated Show resolved Hide resolved
content/python/concepts/operators/operators.md Outdated Show resolved Hide resolved
content/python/concepts/operators/operators.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Collaborator

@raditya1117 raditya1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed typo Fixing a typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants