Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept entry dart loops. Adresses issue #4249 #4499

Merged
merged 30 commits into from
May 18, 2024
Merged

Concept entry dart loops. Adresses issue #4249 #4499

merged 30 commits into from
May 18, 2024

Conversation

kamlesh-ops
Copy link
Contributor

@kamlesh-ops kamlesh-ops commented Mar 29, 2024 •
edited

Description

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@letsbuildanything letsbuildanything self-assigned this Apr 1, 2024
@letsbuildanything letsbuildanything added new entry New entry or entries status: under review Issue or PR is currently being reviewed dart Dart entries labels Apr 1, 2024
letsbuildanything
letsbuildanything requested changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@letsbuildanything letsbuildanything left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamlesh-ops I've listed below some changes. Please make them ASAP.
Also, When referring to elements as they appear in code (properties, methods, functions, commands, expressions, etc.), use backticks i.e. `for` instead of double quotes("for").

content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
content/dart/concepts/loops/loops.md Outdated Show resolved Hide resolved
@letsbuildanything
Copy link
Collaborator

@kamlesh-ops It's been more than a month since the request was made. Please proceed with implementing all the suggested modifications.
Thank you!

kamlesh-ops and others added 17 commits May 14, 2024 18:54
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
664e6fd 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
3117ba4 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
b716b1f 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
2518145 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
04ffdcc 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
2c3e968 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
b801a8e 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
344393e 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
1e8abd0 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
7f782f1 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
9d32f61 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
8bef77c 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
99910b6 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
2a0be87 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
8677534 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
ce877a7 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
6743b5a 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
kamlesh-ops and others added 3 commits May 14, 2024 20:21
@kamlesh-ops
Update loops.md
e5e838d
@kamlesh-ops @letsbuildanything
Update content/dart/concepts/loops/loops.md
f1d07fe 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
@kamlesh-ops
change 'num' to 'n'
3907948
@kamlesh-ops
Copy link
Contributor Author

@letsbuildanything I am extremely sorry for the delay. I have made the changes. Please review.
Thank you!

letsbuildanything
letsbuildanything approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamlesh-ops Thank you for making the changes. It seems ready for the next review!

@mohitO12-dev mohitO12-dev self-assigned this May 17, 2024
@mohitO12-dev mohitO12-dev added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 17, 2024
mohitO12-dev
mohitO12-dev approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@mohitO12-dev mohitO12-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mohitO12-dev mohitO12-dev merged commit 45e74c2 into Codecademy:main May 18, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @kamlesh-ops
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/dart/loops

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@mohitO12-dev mohitO12-dev added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letsbuildanything letsbuildanything letsbuildanything approved these changes

@mohitO12-dev mohitO12-dev mohitO12-dev approved these changes

Assignees

@letsbuildanything letsbuildanything

@mohitO12-dev mohitO12-dev

Labels
dart Dart entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kamlesh-ops @letsbuildanything @mohitO12-dev @dakshdeepHERE