Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Term Entry] Dart Maps .remove() #4420

Merged
merged 22 commits into from
May 14, 2024
Merged

[Term Entry] Dart Maps .remove() #4420

merged 22 commits into from
May 14, 2024

Conversation

dancikmad
Copy link
Contributor

@dancikmad dancikmad commented Feb 27, 2024 •
edited by Sriparno08

Description

  • Added the List.remove() method for Dart

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@avdhoottt avdhoottt self-assigned this Feb 27, 2024
@avdhoottt avdhoottt added new entry New entry or entries status: under review Issue or PR is currently being reviewed dart Dart entries labels Feb 27, 2024
avdhoottt
avdhoottt requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dancikmad, I noticed that you have mentioned list.remove() method in the content, please change it to map.remove(). Ping me when you are done with it.

content/dart/concepts/map/terms/remove/remove.md Outdated
- 'paths/computer-science'
---

In Dart, the **`.remove()`** method is used to remove the first occurence of a specified value from the list. This method is useful when a particular element from a list has to be removed without knowing it's index. It returns true if the specified value is removed from the list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is for Map concept so you need to write the content in reference to Maps. You have mentioned lists everywhere in the content, please replace it.

@dancikmad
Copy link
Contributor Author

@avdhoottt Hi, yeah I know. My mistake ... I realised this morning after I went through the doc again.
Will work on it today and replace and push the change.
Thank you mate

@avdhoottt
Copy link
Collaborator

Hey @dancikmad Are you working on this PR?

@dancikmad
Copy link
Contributor Author

@avdhoottt Yes, I have redone it, I will push the change later this evening. Sorry for the delay, been busy with a side project this week.

@avdhoottt
Copy link
Collaborator

Hey @dancikmad, I think you have mistakenly committed package.json and yarn.lock. Please can you delete them from this PR?

avdhoottt
avdhoottt requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dancikmad, please make these final changes!!

content/dart/concepts/map/terms/remove/remove.md Outdated
map_name.remove(key)
```

- `key`: The key of the entry to be removed from the map.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains plagiarism, please change it.

content/dart/concepts/map/terms/remove/remove.md Outdated Show resolved Hide resolved
content/dart/concepts/map/terms/remove/remove.md Outdated Show resolved Hide resolved
content/dart/concepts/map/terms/remove/remove.md Outdated Show resolved Hide resolved
avdhoottt
avdhoottt approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the second review!!

@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 14, 2024
@Sriparno08 Sriparno08 self-assigned this May 14, 2024
Sriparno08
Sriparno08 approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@Sriparno08 Sriparno08 merged commit 091a053 into Codecademy:main May 14, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @dancikmad
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/dart/map/remove

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@avdhoottt avdhoottt

@Sriparno08 Sriparno08

Labels
dart Dart entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Dart Maps .remove()
3 participants
@dancikmad @avdhoottt @Sriparno08