Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest MUI #214

Closed
wants to merge 4 commits into from
Closed

Upgrade to latest MUI #214

wants to merge 4 commits into from

Conversation

kelvinkipruto
Copy link
Contributor

Description

Upgrade to the lates MUI Version

Fixes #213

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Sep 15, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pesayetu ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 10:19AM (UTC)

@kelvinkipruto
Copy link
Contributor Author

@kilemensi @esirK @thepsalmist The site is now running, but the css is broken. From the migration docs , it is due to the existence of the old @material-ui/core in one of the dependencies, which I have found out to be @commons-ui/core which is created by CFA . What would be the best approach to handle this? Do we proceed to upgrade @commons-ui/core also to MUI 5 or create the imported components and get rid of it, then probably refractor them as packages once we move to the monorepo?

@esirK
Copy link
Contributor

esirK commented Sep 16, 2022

@material-ui/core

@kelvinkipruto
I think you might be referencing an old commons-ui Checking on the commons-ui we have in the mono repo, I see this upgrade was already made.

@kelvinkipruto kelvinkipruto mentioned this pull request Oct 19, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi Awaiting requested review from kilemensi

@esirK esirK Awaiting requested review from esirK

@thepsalmist thepsalmist Awaiting requested review from thepsalmist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade MUI to latest version
2 participants
@kelvinkipruto @esirK