Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 create and endpoint to add product to cart #101

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

Palisar
Copy link
Contributor

@Palisar Palisar commented Feb 13, 2022

Reopen this and fixed up the issues from before where the endpoint was returning a guid instead of a CartResponse
I'm not sure about @Rich-Dunne's side of this PR but the API side is done.

@Palisar Palisar added api anything related to the back-end refactor refactoring code task Describes a child task of a user story labels Feb 13, 2022
@Palisar Palisar added this to In progress in API via automation Feb 13, 2022
@Palisar Palisar added this to the MVP milestone Feb 13, 2022
@Rich-Dunne
Copy link

I'm no longer working on this.

@valincius
Copy link
Member

I briefly tested this out - I noticed that after I add to cart, nothing really happens on the frontend.
I think it should reset the "add to cart" quantity, and maybe show a alert or something saying that it was added successfully. Might also want to show something like "You have X quantity in your cart" if an item is already in our cart.

@valincius valincius closed this Feb 15, 2022
API automation moved this from In progress to Done Feb 15, 2022
@valincius valincius reopened this Feb 15, 2022
API automation moved this from Done to In progress Feb 15, 2022
@Palisar
Copy link
Contributor Author

Palisar commented Feb 16, 2022

I was more so trying to push the back end side of this, I think someone else had been working on the same branch and we may have gotten our work mixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api anything related to the back-end refactor refactoring code task Describes a child task of a user story
Projects
API
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants