Improved default settings #707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitphage
moved this from Development - In progress
to Development - Done
in Current Development
bitphage
moved this from Development - Done
to Review - In progress
in Current Development
bitphage
requested changes
Mar 11, 2020
| 'Amount is expressed as a percentage of the account balance of quote/base asset', None), | ||
| ConfigElement('spread', 'float', 5, 'Spread', | ||
| 'The percentage difference between buy and sell', (0, 100, 2, '%')), | ||
| ConfigElement('dynamic_spread', 'bool', False, 'Dynamic spread', | ||
| 'Enable dynamic spread which overrides the spread field', None), | ||
| ConfigElement('market_depth_amount', 'float', 0, 'Market depth', | ||
| ConfigElement('market_depth_amount', 'float', 99, 'Market depth', |
There was a problem hiding this comment.
Should not be 99 as different assets have different value. Better keep 0 here.
| 'How many percent will own spread be compared to market spread?', | ||
| (0.01, 1000, 2, '%')), | ||
| ConfigElement('center_price', 'float', 0, 'Center price', | ||
| 'Fixed center price expressed in base asset: base/quote', (0, None, 8, '')), | ||
| ConfigElement('center_price_dynamic', 'bool', True, 'Measure center price from market orders', | ||
| 'Estimate the center from closest opposite orders or from a depth', None), | ||
| ConfigElement('center_price_depth', 'float', 0, 'Measurement depth', | ||
| ConfigElement('center_price_depth', 'float', 999, 'Measurement depth', |
| 'Cumulative quote amount from which depth center price will be measured', | ||
| (0.00000001, 1000000000, 8, '')), | ||
| ConfigElement('center_price_from_last_trade', 'bool', False, 'Last trade price as new center price', | ||
| 'This will make orders move by half the spread at every fill', None), | ||
| ConfigElement('center_price_offset', 'bool', False, 'Center price offset based on asset balances', | ||
| ConfigElement('center_price_offset', 'bool', True, 'Center price offset based on asset balances', |
There was a problem hiding this comment.
I think it's better to leave this to the user.
There was a problem hiding this comment.
I think it is better to leave this to the users with 'true', because false makes no sense for RO strategy.
There was a problem hiding this comment.
It's really depends on how it's being used.
Current Development
automation
moved this from Review - In progress
to Development - In progress
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.