Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple CDN sources #771

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

santam85
Copy link

@santam85 santam85 commented May 14, 2024

Allows to declare multiple CDN sources in your Podfile, even if one of them does not fully mirror the trunk.
Removes the requirement to provide empty shards for the version metadata files of non-existing pods on a CDN repo.

Prevents errors like:

### Error

Errno::ENOENT - No such file or directory @ rb_sysopen - /Users/nathan/.cocoapods/repos/pods-private/all_pods_versions_4_0_1.txt

Fixes #768
Fixes CocoaPods/CocoaPods#12338

@igor-makarov
Copy link
Contributor

This doesn't look like working code - there seems to be at least one undefined merhod.

@maikelvdh
Copy link

This doesn't look like working code - there seems to be at least one undefined merhod.

Would you mind to elaborate on it further? I have been leveraging similar patch for identical usecase as @santam85 and this seems to work for the use case.

@santam85
Copy link
Author

The added line is using local_file_okay? from

def local_file_okay?(partial_url)

@santam85
Copy link
Author

@orta @segiddins @paulb777 can you have a look at this one please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants