Fix crash when retrieve subspec from a unavailable podspec file #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch as `AFNetorking (= 1.1.1)`
amorde
force-pushed
the
fix_subspec_by_name
branch
from
2b4b9a8
to
a7e5ca7
Compare
amorde
approved these changes
Dec 24, 2023
amorde
force-pushed
the
fix_subspec_by_name
branch
from
a7e5ca7
to
f13b963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When install a subspec such as
AFNetworking/Reachabilitywith no version range is specified:Cocoapods will crashed:
Same issue mentioned here: CocoaPods/CocoaPods#11733
After some research, I found it caused by AFNetworking (= 1.1.1), this
podspec.jsonhas empty contents:{ "deprecated_in_favor_of": "Alamofire", "platforms": { "osx": null, "ios": null, "tvos": null, "watchos": null } }so I add some check code in
subspec_by_namemethod, and now no more crash occurs.