Prateek Murgai: Small changes for the system. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 13, 2014 22:10
Changed 'runObjectProposals' to 'runObjectProposal'
New fields have been added which might be of use of further evaluation.
Possible function to fix the bug in PlotMetric.m : No getMethods() found in PlotMetric
Function that loads paths for pascal images, best candidate, imagenet_2013 etc .
Precalculated files which can be used for plotting purposes, while comparing with ground truth. Use these files when running PlotMetric.m
Proposals calculated for endres for the demo images
Chnaged name in the M file from 'greedy_matching_rowwise' to 'maxRow'
No getMethods() found in the repository which is being called in the plotMetric function. A possible bugfix is mentioned as comments in the M file.
This field is being called in the compute_best_recall_candidates () function which is not present in your current methods.mat file.
|
Prateek, can you please take a look at the new README file and make changes according to it. |
|
Also, @prateek64 : if you could create another branch for each feature you patch/fix. Merging into the main branch is not a good idea, we can always merge the work into main branch after we are sure its good to be added for a stable release. |
|
I will go through the new ReadMe also , @nchavali , Please can you change the 'runObjectProposals()' to 'runObjectProposal()' in your ReadMe in ii) and iii) under the Generating Proposals heading. Your function name is without the 's'. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.