WIP Pivot subtotal styles #1821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the side of caution e.g. self closing targe are considered different, different order of attributes is considered different.
…gnificant for XML, but it is significant for XNode.DeepEquals).
|
Hi, I definitely want to review this one before merging, please. |
|
@igitur It is missing ability to load saved file that has subtotals in some fields and and not in others. I had some problems with XML comparing, so I worked on it. It is mostly to solve issue that I can't style functions other than default subtotal. |
…est files, in most cases it removes defaultSubtotal from fields that shouldn't have subtotal (e.g. fields unused in the table or data fields)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ability to remove a subtotal from a pivot table and fix the styles. ClosedXML should be clear that default subtotal is in the field. ASIS - empty Subtotals mean default, TOBE - empty subtotals means no subtotal, XLSubtotalFunction.Automatic means default, any additional subtotal function overrides the default.
It modifies the API, from
XLPivotField.AddSubtotal(XLSubtotalFunction)toXLPivotField.SetSubtotal(XLSubtotalFunction, bool), but it is either this or additional functions likeRemoveSubtotal. Since it is not possible to affect the order of subtotals, this seems better.Second thing is styling - it's not possible to style other subtotal function other than default one. even this is a partial solution, because it doesn't style label of a subtotal, but at least it is an improvement.