Fix call calculated value invalidation if named ranges are changed (#1536) #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
force-pushed
the
1536-cache-invalidation
branch
from
afdc494
to
3ab2696
Compare
|
Rebased. |
igitur
force-pushed
the
1536-cache-invalidation
branch
from
3ab2696
to
f35fa22
Compare
|
I got this error.. when will the bug be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Previously, when checking if cell cached value has to be recalculated, we only analyzed precedent cells. But if a formula uses named ranges and they start to point to another location, the cached value was not properly invalidated. Now, instead of
PrecedentCells, we obtain a collection consisting of named ranges and cells (underIXLVersionableinterface) that affect the current cell.I also had to remove
ExpressionCachefromCalcEnginebecause it might store a reference to the old range after a named range was modified.