Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug #417 #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug #417 #418

wants to merge 1 commit into from

Conversation

mohataher
Copy link

So evolutionary_search library did not pass their test cases.

On cv.EvolutionaryAlgorithmSearchCV class, it extends sklearn.model_selection._search.BaseSearchCV which requires _run_search method to be implemented. This method is not implemented on the library and therefore, it threw the error

TypeError: Can't instantiate abstract class EvolutionaryAlgorithmSearchCV with abstract methods _run_search

According to the implementation here at sklearn_deep, the method was ignored.

Therefore, I created a class that inherits EvolutionaryAlgorithmSearchCV and ignored that method.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.4%) to 69.767% when pulling d75e0c2 on mohataher:master into 4b7e0e7 on ClimbsRocks:master.

@mohataher
Copy link
Author

The overall coverage is seriously dropped. I'm happy to write test cases to get that back up. But I'm concerned this library is no longer maintained since @ClimbsRocks hasn't responded here or anywhere else in the past few weeks/months.

If you are still actively maintaining this, please let me know.

@mohataher
Copy link
Author

@chjq201410695 have you pulled my changes on this fork? https://github.com/mohataher/auto_ml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants