Enhance MultiregionGrid with Conditional Halo Extensions and Debugging Capabilities
#3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
156
to
157
| fill_halo_regions!(U) | ||
| fill_halo_regions!(V) |
There was a problem hiding this comment.
actually, this would work for multiregion, but I think it would not work for a cubed sphere where we need to fill U and V together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as an important step toward integrating the split-explicit free surface with
MultiRegionGrid. It introduces an optional parameter,extended_halos, which allows users to control the behavior of halo filling during each substep. Settingextended_halostofalsemaintains the halo size to be the same as the original grid, diverging from the previous default behavior whereextended_halos = truewould automatically extend the halo to cover all split-explicit substeps, significantly enhancing computational performance.Although setting
extended_halostofalsemay be less efficient for long simulations on high-resolutionMultiRegionGridsgrids, this feature is helpful for debugging purposes.Additionally, this PR addresses and resolves a couple of bugs related to the interaction between
ImmersedBoundaryGridandMultiRegionGrid. These modifications ensure thatImmersedBoundaryGridnow correctly wraps overMultiRegionGrid, reversing the prior implementation approach.With @simone-silvestri and @jm-c.