Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiPhase TP-Flash #272

Open
wants to merge 90 commits into
base: master
Choose a base branch
from
Open

MultiPhase TP-Flash #272

wants to merge 90 commits into from

Conversation

longemen3000
Copy link
Member

this PR adds a new multiphase tp-flash.
it is based on the michelsen multiphase method (tpd + RR + gibbs minimization) with some modifications, listed below:

  • the RR calculation of phase fractions was based on a paper by Okuno et al. (2010), it has a good definition of a guarded newton step that allows easy convergence.
  • the gibbs minimization was done in lnK-β-v space (volume solver) instead of mole numbers.
  • the creation of new phases is done by using the result of the stability calculation to create a new phase, instead of using wilson k values. if we don't have critical points, this is faster.

This PR also speeds up tpd significantly, to the point it is safe to call it multiple times.
supercedes #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants