CU-86dt1fxtx-1 - Implement Contextual Messages on WcSdk on both sides #116
Conversation
| @@ -32,7 +33,7 @@ function HelloWorld() { | |||
|
|
|||
| const getMyBalance = async (): Promise<void> => { | |||
| try { | |||
| const resp = await wcSdk.testInvoke({ | |||
| const resp = await wcSdk.withContext(context).testInvoke({ | |||
There was a problem hiding this comment.
You've replaced all the calls to use withContext but I think we shouldn't do this.
This makes it look like the context message is mandatory, and since it's optional, it will not be used always. Let's simply create a new test method that contains a hardcoded context message to be used as example.
| Dapp method invocation context (optional): | ||
| <br></br> | ||
| <textarea | ||
| data-testid="hello-world__contextual_message" | ||
| placeholder="Write a context message for method invocation" | ||
| onChange={(event) => setContext(event.target.value)} | ||
| /> | ||
| <br></br> |
There was a problem hiding this comment.
I don't think we need this, let's keep the examples simple, let's just use an hardcoded context message
| @@ -79,6 +80,7 @@ export const DEFAULT_AUTO_ACCEPT_METHODS: Method[] = [ | |||
| 'getNetworkVersion', | |||
| 'calculateFee', | |||
| 'wipeRequests', | |||
| //'withContext' | |||
LeonardoDizConde
force-pushed
the
CU-86dt1fxtx-1
branch
2 times, most recently
from
5f5d4a0
to
b932014
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -59,6 +61,12 @@ export default function RequestCard( | |||
| Neo3 | |||
| </Text> | |||
| </Flex> | |||
| <Text fontSize="0.875rem" color="#888888" fontWeight="bold" mt="0.875rem"> | |||
There was a problem hiding this comment.
Ensure that the color #888888 is consistent with the theme or color scheme of the application. If there is a theme file or constants for colors, consider using that instead of hardcoding the color value.
| Method Contextual Message | ||
| </Text> | ||
| <Text fontSize="0.875rem" mt="0.5rem" data-testid="request-card__contextual_message"> | ||
| {contextualMessage} |
There was a problem hiding this comment.
The data-testid attribute value request-card__contextual_message should follow a consistent naming convention. Verify that it aligns with other data-testid values throughout the project for consistency.
| await connectReactDappToNewReactAccount(context, dappPage, walletPage) | ||
| await dappPage.awaitAndClickTestId('hello-world__verify-with-context') | ||
| await acceptPendingRequestToReactWallet(walletPage, async (walletPageBeforeAcceptMethod) => { | ||
| const contextMessage = await walletPageBeforeAcceptMethod.awaitAndGetTestId('request-card__contextual-message') |
There was a problem hiding this comment.
Ensure that the test ID request-card__contextual-message is consistently used across all relevant test files to avoid potential discrepancies in element targeting.
LeonardoDizConde
force-pushed
the
CU-86dt1fxtx-1
branch
from
74dd62c
to
983a9ca
Compare
| @@ -31,6 +31,8 @@ export default function RequestCard( | |||
| props.closeRequest() | |||
| } | |||
|
|
|||
| const contextualMessage = String(request.params.contextualMessage).trim() | |||
There was a problem hiding this comment.
Ensure that request.params.contextualMessage exists before converting it to a string and trimming it. This could potentially throw an error if contextualMessage is undefined or not present in request.params.
No description provided.