CU-86dt27bzj - Create a WcSdk method to wipe all requests from a dapp #114
Conversation
… -> adding a toast to prevent breaking the app when wiping the requests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,6 +2,9 @@ import React, { useState } from 'react' | |||
| import { TypeChecker } from '@cityofzion/neon-dappkit-types' | |||
| import { NetworkType, useWalletConnect, SignMessageVersion } from '@cityofzion/wallet-connect-sdk-react' | |||
| import { dappMethods, networks } from '../Constants' | |||
| import 'toastify-js/src/toastify.css' | |||
There was a problem hiding this comment.
Consider importing CSS in a central file or at the root level of your application. This will help to keep all style imports in one place and improve code organization.
| @@ -2,6 +2,9 @@ import React, { useState } from 'react' | |||
| import { TypeChecker } from '@cityofzion/neon-dappkit-types' | |||
| import { NetworkType, useWalletConnect, SignMessageVersion } from '@cityofzion/wallet-connect-sdk-react' | |||
| import { dappMethods, networks } from '../Constants' | |||
| import 'toastify-js/src/toastify.css' | |||
| // @ts-ignore | |||
| import Toastify from 'toastify-js' | |||
There was a problem hiding this comment.
Avoid using @ts-ignore as it suppresses all typescript errors in the next line. If there's a specific error you want to ignore, use @ts-expect-error instead and provide a comment explaining why the error is being ignored.
| signers: [{ scopes: 1 }], | ||
| }) | ||
|
|
||
| console.log(resp) |
There was a problem hiding this comment.
Avoid using console.log for debugging in production code.
| signers: [{ scopes: 1 }], | ||
| }) | ||
|
|
||
| console.log(resp) |
There was a problem hiding this comment.
Avoid using window.alert for debugging in production code.
| ], | ||
| signers: [{ scopes: 1 }], | ||
| }) | ||
| console.log(resp) |
There was a problem hiding this comment.
Avoid using console.log for debugging in production code.
| console.log(resp) | ||
| window.alert(JSON.stringify(resp, null, 2)) | ||
| } catch (e) { | ||
| onError(e) |
There was a problem hiding this comment.
Consider providing a more descriptive error message in the onError function to help with debugging.
| @@ -336,46 +390,60 @@ function HelloWorld() { | |||
| console.log(resp2) | |||
There was a problem hiding this comment.
Avoid using console.log for debugging in production code. It's better to use a logging library that can be toggled for development/production.
| }, | ||
| ], | ||
| }) | ||
| console.log(resp) |
There was a problem hiding this comment.
Avoid using console.log for debugging in production code. It's better to use a logging library that can be toggled for development/production.
| setResponse(JSON.stringify(resp, null, 2)) | ||
| try { | ||
| const resp = await wcSdk.wipeRequests() | ||
| console.log(resp) |
There was a problem hiding this comment.
Avoid using console.log for debugging in production code. It's better to use a logging library that can be toggled for development/production.
| } | ||
| } | ||
|
|
||
| const onError = (error: any) => { |
There was a problem hiding this comment.
Consider adding types to your function parameters for better type safety. Instead of any, use a specific type or create an interface for the error object.
adding a toast to prevent breaking the app when wiping the requests