Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public decorator signature is misleading #1253

Merged
merged 1 commit into from
May 24, 2024
Merged

public decorator signature is misleading #1253

merged 1 commit into from
May 24, 2024

Conversation

luc10921
Copy link
Collaborator

Related issue
#1222

Summary or solution description
Fixing the wrong default value on the safe parameter at the public decorator

Platform:

  • OS: Windows 11 x64
  • Python version: Python 3.11

@luc10921 luc10921 requested a review from meevee98 May 16, 2024 17:52
@luc10921 luc10921 self-assigned this May 16, 2024
@melanke
Copy link
Collaborator

melanke commented May 16, 2024

Task linked: CU-86dtg2t0d public decorator signature is misleading

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.215%. remained the same
when pulling 704d68b on CU-86dtg2t0d
into 49731b6 on development.

@meevee98 meevee98 merged commit fee3716 into development May 24, 2024
5 checks passed
@meevee98 meevee98 deleted the CU-86dtg2t0d branch May 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meevee98 meevee98 meevee98 approved these changes

Assignees

@luc10921 luc10921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luc10921 @melanke @coveralls @meevee98