CU-86dt9vq5z - Implement a new import structure #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86dt9vq5z Implement a new import structure |
meevee98
requested changes
May 13, 2024
| @@ -50,7 +48,7 @@ def get_value(self, symbol_id) -> Any: | |||
|
|
|||
| :return: the value if this type has this symbol. None otherwise. | |||
| """ | |||
| from boa3.builtin.interop.contract import CallFlags | |||
| from boa3.sc.types import CallFlags | |||
There was a problem hiding this comment.
is this import necessary? there is a CallFlags import outside the class
Comment on lines
20
to
37
| # Deprecated Native Contract Names | ||
| gas_name = 'GAS' | ||
| ledger_name = 'Ledger' | ||
| neo_name = 'NEO' | ||
| oracle_name = 'Oracle' | ||
| policy_name = 'Policy' | ||
|
|
||
| GAS_ = GAS.clone() | ||
| GAS_._identifier = gas_name | ||
| Ledger_ = Ledger.clone() | ||
| Ledger_._identifier = ledger_name | ||
| NEO_ = NEO.clone() | ||
| NEO_._identifier = neo_name | ||
| Oracle_ = Oracle.clone() | ||
| Oracle_._identifier = oracle_name | ||
| Policy_ = Policy.clone() | ||
| Policy_._identifier = policy_name | ||
|
|
There was a problem hiding this comment.
for the classes that were renamed you can set the id on the package definition instead of here (see next comments)
Comment on lines
54
to
57
| GasModule = Package(deprecated=True, | ||
| new_location='boa3.sc.contracts', | ||
| identifier=gas_name.lower(), | ||
| types=[GAS_] |
There was a problem hiding this comment.
Suggested change
| GasModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=gas_name.lower(), | |
| types=[GAS_] | |
| GasModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=gas_name.lower(), | |
| other_symbols={ | |
| gas_name: GAS | |
| } |
Comment on lines
60
to
63
| LedgerModule = Package(deprecated=True, | ||
| new_location='boa3.sc.contracts', | ||
| identifier=ledger_name.lower(), | ||
| types=[Ledger_] |
There was a problem hiding this comment.
Suggested change
| LedgerModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=ledger_name.lower(), | |
| types=[Ledger_] | |
| LedgerModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=ledger_name.lower(), | |
| other_symbols={ | |
| ledger_name: Ledger | |
| } |
Comment on lines
66
to
69
| NeoModule = Package(deprecated=True, | ||
| new_location='boa3.sc.contracts', | ||
| identifier=neo_name.lower(), | ||
| types=[NEO_] |
There was a problem hiding this comment.
Suggested change
| NeoModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=neo_name.lower(), | |
| types=[NEO_] | |
| NeoModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=neo_name.lower(), | |
| other_symbols={ | |
| neo_name: NEO | |
| } |
Comment on lines
72
to
75
| OracleModule = Package(deprecated=True, | ||
| new_location='boa3.sc.contracts', | ||
| identifier=oracle_name.lower(), | ||
| types=[Oracle_] |
There was a problem hiding this comment.
Suggested change
| OracleModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=oracle_name.lower(), | |
| types=[Oracle_] | |
| OracleModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=oracle_name.lower(), | |
| other_symbols={ | |
| oracle_name: Oracle | |
| } |
Comment on lines
78
to
81
| PolicyModule = Package(deprecated=True, | ||
| new_location='boa3.sc.contracts', | ||
| identifier=policy_name.lower(), | ||
| types=[Policy_] |
There was a problem hiding this comment.
Suggested change
| PolicyModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=policy_name.lower(), | |
| types=[Policy_] | |
| PolicyModule = Package(deprecated=True, | |
| new_location='boa3.sc.contracts', | |
| identifier=policy_name.lower(), | |
| other_symbols={ | |
| policy_name: Policy | |
| } |
meevee98
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary or solution description
Added a new folder
boa3.scand deprecated the oldboa3.builtinPlatform: