TAN-1589: Issue id - 18831: make cards accessible

[EdwinKato]

Changelog

Fixed

• Fix accessibility issues on event cards

[notion-workspace]

4.1.2: Fix Name, role, value (A) failures

[cl-dev-bot]

	Warnings
⚠️	The changelog is empty. What should I put in the changelog?
⚠️	The PR title contains no Jira issue key (case-sensitive)
⚠️	The branch name contains no Jira issue key (case-sensitive)

	Messages
📖	Run the e2e tests
📖	Check translation progress

Generated by 🚫 dangerJS against 65bda2b

[EdwinKato]

On this one, I have fixed the key issues pointed out. That is, relating to using the role button on cards. There are a number of cards in the app that could be improved but that will take more effort than needed if they are not issues that been reported directly.

Some of the improvements that could be made would be:

• Make sure all cards used as lists are in list element syntax. (This would entail looking at each card and it's use case and styling outside where it is used)
• Look at the structure of each card and ensure we are using proper html syntax for all of them

[brentguf]

Before looking at the issues with the existing code, I wonder if we shouldn't first take a step back and reimplement the card as they do in the guide linked to by AnySurfer. Have you been able to take a look at that?

[EdwinKato]

Before looking at the issues with the existing code, I wonder if we shouldn't first take a step back and reimplement the card as they do in the guide linked to by AnySurfer. Have you been able to take a look at that?

I am actually doing that in the primary event card. I have picked things in the implementation that apply to the use case. The pseudo content trick for example is what we are using to extend the link area in the event card in EventInformation.

[brentguf]

I am approving this because it works functionally, but there are some code changes that I would very much like to see merged into this one. :) See this PR. (For some reason, the focus states of the event preview cards work better in the branch of that PR as well.)