Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAN-1803] New activities endpoint & filtering for management feed #7856

Closed
wants to merge 35 commits into from
Closed

[TAN-1803] New activities endpoint & filtering for management feed #7856

wants to merge 35 commits into from

Conversation

jinjagit
Copy link
Contributor

@jinjagit jinjagit commented May 10, 2024 •
edited

WIP

  • Repurposes a redundant index action. Not sure yet if we need a show action.
  • Filters scope first in policy, to just the selected activities that may be shown in the new 'Management Feed'
  • Uses query param filtering by user_ids or project_ids (all 'Management Feed' activities have a relation to user who acted)
  • Introduces a new activity for action: 'changed_publication_status', item_type: ‘Project’
  • Examples of request params in use
  • Examples of responses for each activity type we have selected for the 'Management Feed'

Notes on selected action: 'changed' activities

  • Uses only action: 'changed' activities to cover updates to projects and phases.
    We could produce specific activities per updated attribute (like we already do for phases, here). However, at this point, minimising the number of kinds of activities we use for the Management Feed is probably best.
  • Uses the existing serialized :change attribute to detail the changes to attributes resulting from an update action, in the payload of the 'changed' activities (also with the key :change).
    Re-using the existing :change attribute is probably be simpler for the FE to use, compared to introducing a new :changes (plural) attribute, but this could prove to be wrong.
  • Prevents the creation of a 'changed' activity for a project, when no project attribute has been updated.
    Previously, this could happen when the associated admin_publication.publication_status was changed.
    Now that we use the payload of a 'changed' activity to provide details of the update, this avoids showing a changed activity with no details of any updated attribute(s).

Changelog

Technical

  • [TAN-1803] New activities endpoint & filtering for management feed

@jinjagit jinjagit self-assigned this May 10, 2024
@notion-workspace Notion Workspace
Copy link

👷 Filter a specific subset of admin/PM action related activities via the index action

@jinjagit jinjagit marked this pull request as draft May 10, 2024 08:40
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented May 10, 2024 •
edited

Warnings
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖 Changelog provided 🎉
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 4ac0f29

@jinjagit
[TAN-1803] POC basic filtering in policy scope of management activities
cf77a0f
@jinjagit
[TAN-1084] POC basic filtering by user_id(s) or project_id(s)
1f12659
@jinjagit
[TAN-1084] Bugfix build scope incrementally in resolve method
1173ea9
@jinjagit
[TAN-1084] Fix acceptance tests
3075f65
@jinjagit
[TAN-1084] Simplify policy + tests for non-management activity
13d7e57
@jinjagit
[TAN-1084] Serialize item_type, item_id, project_id
7d94a6f
@jinjagit
[TAN-1084] Check admin is also active in policy
9f9d962
@jinjagit
[TAN-1084] Add Project changed activity to scope + include changes in…
a5032ee 
… payload
@jinjagit
[TAN-1084] Fix test of project side_fx after_update
d02ffae
@jinjagit
[TAN-1084] App project published activity to scope
f180998
@jinjagit
[TAN-1803] Do not create changed activity when no project attribute u…
5658291 
…pdated

This would happen if only updates to the associated admin_publication
were made. e.g. updating the publication_status
@jinjagit
[TAN-1803] New publication_status_changed activity for project
43ec65d 
Covers the cases where admin_publication publication_status is
changed, but no published activity would be produced
@jinjagit
[TAN-1803] Use item_id or project_id when filtering by project(s)
8a6bf28
@jinjagit
[TAN-1803] Add project activity factories
43839fd
@jinjagit
[TAN-1803] Add change to phase changed activity
fe979d0
@jinjagit
[TAN-1803] Fix side_fx_phase_spec test
d45a609
@jinjagit
[TAN-1803] Use new activities.for_projects scope
a5b2a93
@jinjagit
[TAN-1803] Add test to side_fx_project_service_spec
0da0f44
@jinjagit
[TAN-1803] Add manual campaign types to scope
3564fdb
@jinjagit
[TAN-1803] Add project_id to sent activity for ManualProjectParticipa…
11b90fa 
…nts campaign
@jinjagit
[TAN-1803] Add test of project_id in sent activity for ManualProjectP…
b84e090 
…articipants
@jinjagit
[TAN-1803] Simplify setting project_id in LogActivityJob
b508c9f
@jinjagit
[TAN-1803] Add Ideea deleted action to scope
0fbae8f
@jinjagit
[TAN-1803] Improve acceptance test
a9239f0
@jinjagit
Copy link
Contributor Author

Closed, in favor of simpler approach: #7888

@jinjagit jinjagit closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jinjagit jinjagit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinjagit @cl-dev-bot