Various widgets release #7833
Merged
Various widgets release #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-timeline-widget-deltas
|
adessy
requested changes
May 22, 2024
| @@ -6,23 +6,39 @@ | |||
| subject(:query) { described_class.new(build(:user)) } | |||
|
|
|||
| describe '#run_query' do | |||
| before do | |||
| FactoryBot.rewind_sequences | |||
There was a problem hiding this comment.
This should not be necessary.
| # conversion rate on the FE, where we only compare | ||
| # visitors (i.e. people that accepted cookies) | ||
| # to active users that also accepted cookies | ||
| active_visitor_users_whole_period_query = { |
There was a problem hiding this comment.
I find the name active_visitor_users a bit confusing. If that's about cookies, maybe we could explicitly say it in the name.
| @dimension_date_sept = create(:dimension_date, date: @date_september) | ||
| @dimension_date_oct = create(:dimension_date, date: @date_october) | ||
| create(:dimension_type, name: 'idea', parent: 'post') | ||
| create(:dimension_type, name: 'comment', parent: 'idea') |
There was a problem hiding this comment.
You can also use Analytics::PopulateDimensionsService.populate_types
...ommercial/report_builder/spec/services/report_builder/queries/analytics/active_users_spec.rb
Show resolved
Hide resolved
...g/components/ReportBuilder/Widgets/ChartWidgets/ActiveUsersWidget/ActiveUsersCard/Narrow.tsx
Show resolved
Hide resolved
...ting/components/ReportBuilder/Widgets/ChartWidgets/ActiveUsersWidget/ChartWidgetSettings.tsx
Outdated
Show resolved
Hide resolved
...ting/components/ReportBuilder/Widgets/ChartWidgets/ActiveUsersWidget/useActiveUsers/parse.ts
Outdated
Show resolved
Hide resolved
...eporting/components/ReportBuilder/Widgets/ChartWidgets/PostsByTimeWidget/PostsByTimeCard.tsx
Show resolved
Hide resolved
front/cypress/e2e/report_builder/widgets/participants_timeline_widget.cy.ts
Show resolved
Hide resolved
luucvanderzee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
Added