[TAN-1768] Add user last_login_at column and functionality

[jinjagit]

WIP (experimental)

Changelog

[notion-workspace]

Add User last_login_at functionality

[jinjagit]

@alexander-cit I'm interested in your opinion on this experimental PR.

It seems the only unique event (that I have found) that can be used to reliably capture a login event is the encoding of a new JWT token. This seems to capture both email and SSO logins, and avoid false-positives.

Inserting the method to write to the User record into a branch of a conditional in the AuthToken#intialize method feels like the wrong way to implement this, however.

Is my approach the right one, or can you think of a better way to capture login date-times?

If it is correct, then can you think of a more elegant/conventional implementation?

[alexander-cit]

feels like the wrong way to implement this, however.

It's a very good point. AuthToken should probably not have any side effects. E.g., if you want to generate it in the Rails console to be able to log in as some user.

Maybe you could add a method that creates a token and updates the user in AuthToken::Authenticable? Maybe you would not need to query the DB in this case and you could use current_user or something like that.

[jinjagit]

Closed, in favor of #7846