Switch from unzip to yauzl #385
Conversation
The node package “unzip” appears to be pretty much unmaintained, and it has problem with the more recent versions of node. The package “yauzl” (Yet Another UnZip Library) appears to be the most suitable replacement.
This is useful since unzipping all of GWT can be pretty slow.
|
@gagern Thanks for fixing this. |
|
@gagern I hope you considered this ready for review and merge. Maybe we should not assign pull requests before the pull request is ready for review. (The push after the assignment was a bit unexpected, but was included in my review.) |
|
@kranich: Yes, this was ready. When I assign a reviewer, I mean that at that moment I consider the branch complete. Nevertheless, occasionally I think of some related stuff that would fit in nicely with the merge in question, and update the branch. If it doesn't arrive in time, that's no problem since I'd just open another request for that. If it got included in a merge without recieving due review, that would be a bit of bad luck, though, so perhaps I should make an effort to do this less often. |
The node package “unzip” appears to be pretty much unmaintained, and it has problem with the more recent versions of node. The package “yauzl” (Yet Another UnZip Library) appears to be the most suitable replacement.