File events and sanity checks #64 #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
reviewed
Nov 24, 2018
| do | ||
| newBuf <- addBuffer txt | ||
| dispatchFileLoaded $ extOf fname newBuf | ||
| bufDo_ newBuf (setFilename fname) |
There was a problem hiding this comment.
I think we should set the filename first THEN dispatch the event probably :) Remember that even handlers are processed synchronously in-line by default
ChrisPenner
reviewed
Nov 24, 2018
| data Extension = Extension String | UnknownExtension deriving (Eq) | ||
|
|
||
| data FileLoaded | ||
| = FileLoaded Extension BufRef |
There was a problem hiding this comment.
I think the FileLoaded event should probably just pass the whole filepath and the consumer can pull the extension out themselves if they like.
ChrisPenner
reviewed
Nov 24, 2018
| = FileLoaded Extension BufRef | ||
|
|
||
| -- | Trigger an 'App' on a 'Keypress' | ||
| onFileLoaded :: (FileLoaded -> App result) -> App ListenerId |
There was a problem hiding this comment.
If we don't plan to use the result for anything I'd prefer we just set it to () for clarity purposes.
ChrisPenner
reviewed
Nov 24, 2018
| onFileLoaded :: (FileLoaded -> App result) -> App ListenerId | ||
| onFileLoaded actionF = addListener (void <$> actionF) | ||
|
|
||
| -- | Dispatch a 'Keypress' event. |
There was a problem hiding this comment.
copy pasta 'FileLoaded event' 😋
ChrisPenner
reviewed
Nov 24, 2018
| data FileLoaded | ||
| = FileLoaded Extension BufRef | ||
|
|
||
| -- | Trigger an 'App' on a 'Keypress' |
There was a problem hiding this comment.
Keypress -> FileLoaded event😛
ChrisPenner
reviewed
Nov 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's enough file event data to hook the new syntax module. I also added some file related packages to do some basic sanity checks. I guess these will be useful later.