Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding language string for removing an item #863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilsonge
Copy link

@wilsonge wilsonge commented May 9, 2020

Description

Allows overriding the language string per the TODO in the code. Required for the multilingual setup we're using this for in @joomla

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

I'm not 100% on whether this will be a breaking change for people overriding the item template (with the introduction of the new parameter). I think it will be fine but I don't have an implementation of that to hand to test with

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mtriff
Copy link
Member

mtriff commented Dec 19, 2021

This looks great! Can you rebase on the latest version? It would also be nice to have a test for this.

@mtriff mtriff added the changes required Pull request requires changes before it can be merged label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required Pull request requires changes before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants