Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customProperties for optgroup options #822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zilus
Copy link

@Zilus Zilus commented Feb 10, 2020

Description

This fixes bug with options inside optgroup not picking up the correct customProperties.

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mtriff mtriff linked an issue Dec 22, 2021 that may be closed by this pull request
@mtriff mtriff changed the title Fixes #543 Fix customProperties for optgroup options Dec 22, 2021
w8tcha added a commit to w8tcha/Choices that referenced this pull request Sep 18, 2023
@jonnitto
Copy link

I've tested this and it works as described. Would be happy for a merge and a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom properties doesn't work with optgroup
2 participants