New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor OpenAPI integration #7088
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7088 +/- ##
==========================================
- Coverage 79.68% 79.58% -0.11%
==========================================
Files 2632 2663 +31
Lines 131383 132582 +1199
==========================================
+ Hits 104692 105509 +817
- Misses 26691 27073 +382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
internal static class GraphQLNamingHelper | ||
{ | ||
public static string CreateInputTypeName( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create a lib that deals with these things. we have this code at least 3 times now .... it does not matter for this PR ... but we should create a core lib dealing with naming and reformatting names etc...
Summary of the changes (Less than 80 chars)
🆕 New features:
❓To be considered:
Utf8JsonWriterHelper
(or something similar) be moved to a shared location? (write JSON from anIValueNode
)