Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OpenAPI integration #7088

Merged
merged 11 commits into from May 13, 2024
Merged

Refactor OpenAPI integration #7088

merged 11 commits into from May 13, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented May 2, 2024

Summary of the changes (Less than 80 chars)

  • Refactored the OpenAPI integration.

🆕 New features:

  • Optional and configurable query and mutation conventions
  • Union results
  • Deprecation
  • Default values
  • Tags
  • Support for different parameter serialization styles
  • Support for OpenAPI links
  • Caching of GET requests to the same request URI, within the context of a single GraphQL request

❓To be considered:

  • Should Utf8JsonWriterHelper (or something similar) be moved to a shared location? (write JSON from an IValueNode)
  • Will tag naming restrictions be relaxed enough to make this feature worthwhile?

⚠️ Not backwards-compatible.

Copy link

github-actions bot commented May 2, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@glen-84 glen-84 marked this pull request as draft May 3, 2024 12:10
@glen-84 glen-84 marked this pull request as ready for review May 6, 2024 12:17
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 79.58%. Comparing base (f7dfae1) to head (b2eb239).

Files Patch % Lines
...te.OpenApi/Properties/OpenApiResources.Designer.cs 76.92% 6 Missing ⚠️
...tChocolate.OpenApi/Helpers/Utf8JsonWriterHelper.cs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7088      +/-   ##
==========================================
- Coverage   79.68%   79.58%   -0.11%     
==========================================
  Files        2632     2663      +31     
  Lines      131383   132582    +1199     
==========================================
+ Hits       104692   105509     +817     
- Misses      26691    27073     +382     
Flag Coverage Δ
unittests 79.58% <77.50%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


internal static class GraphQLNamingHelper
{
public static string CreateInputTypeName(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a lib that deals with these things. we have this code at least 3 times now .... it does not matter for this PR ... but we should create a core lib dealing with naming and reformatting names etc...

@michaelstaib michaelstaib merged commit 9515881 into main May 13, 2024
6 checks passed
@michaelstaib michaelstaib deleted the gai/refactor-openapi branch May 13, 2024 07:00
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants