Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SSE connection not closing when an exception is thrown #7007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunghwan2789
Copy link
Contributor

Closes #6698

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (00b4fdf) to head (6f2aad0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7007      +/-   ##
==========================================
- Coverage   72.73%   69.78%   -2.95%     
==========================================
  Files        2599     2567      -32     
  Lines      129629   128287    -1342     
==========================================
- Hits        94284    89529    -4755     
- Misses      35345    38758    +3413     
Flag Coverage Δ
unittests 69.78% <100.00%> (-2.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
Copy link
Member

We have completely reworked the formatter here:
#6981

Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge this one as we already have a PR with a new version of this.

@sunghwan2789
Copy link
Contributor Author

We cannot merge this one as we already have a PR with a new version of this.

Are you merging #6981 into v13? If not, I can change the base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSE subscription makes HotChocolate not being shutdown gracefully
2 participants